Partially revert "Suppress ICMP error replies […]", still allow reception by other sockets. #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion by other sockets. This reverts commit f56666a. Adds another test case.
Contributor
|
@m-labs-homu r+ |
|
📌 Commit 503a780 has been approved by |
|
💔 Test failed - status-travis |
Contributor
|
@m-labs-homu r+ |
|
📌 Commit f9e46d1 has been approved by |
m-labs-homu
pushed a commit
that referenced
this pull request
May 8, 2019
…ket-raw" Closes: #295 Approved by: whitequark
|
☀️ Test successful - status-travis |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to steal your time again, but did anyone notice that in #293 I broke normal sockets when a RawSocket was listening on that proto?
This PR reverts most of the changes and moves ICMP reply prevention into
process_udp(). This solves any ICMP errors for the DHCP case but doesn't affect any other non-UDP protocol.The test from #293 is kept, another one is added for this specific problem.
To further improve error reply behaviour in the presence of RawSockets it would probably be useful to let the RawSockets validate incoming packets, so that would practically be a filter...