Add a few DHCP options #255
Conversation
src/wire/ip.rs
Outdated
| } | ||
|
|
||
| /// Treat as subnet mask, get position of first 0 | ||
| pub fn to_prefix_len(&self) -> u8 { |
There was a problem hiding this comment.
Either this function shouldn't be pub, or it should perform more validation and ensure that self is a CIDR subnet mask.
There was a problem hiding this comment.
I pushed another commit now that adds to_prefix_len() with the requested validation. Because the fn can remain pub, Travis-CI should run without any unused fn failures this time.
|
Thanks. Can you please squash? (I wish Homu could do that itself... sadly autosquash is broken on it.) |
|
Squashed. Travis is failing due to this one unused function that is required in #186. |
astro
force-pushed
the
dhcp-wire
branch
2 times, most recently
from
f36715f to
2542a90
Compare
| } | ||
|
|
||
| /// If `self` is a CIDR-compatible subnet mask, return `Some(prefix_len)`, | ||
| /// where `prefix_len` is the number of leading zeroes. Return `None` otherwise. |
There was a problem hiding this comment.
This docstring wasn't particularly great; I fixed it.
|
@m-labs-homu r+ |
|
📌 Commit 565cdad has been approved by |
Closes: #255 Approved by: whitequark
|
☀️ Test successful - status-travis |
3 participants
Separate PR as requested in #186 (comment)