m: Remove futures-lite dependency #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
reviewed
Jan 26, 2023
zeenix
reviewed
Jan 26, 2023
zeenix
reviewed
Jan 26, 2023
zeenix
reviewed
Jan 26, 2023
Member
|
LGTM otherwise. 👍 |
Co-authored-by: Zeeshan Ali Khan <[email protected]>
zeenix
approved these changes
Jan 26, 2023
Merged
taiki-e
reviewed
Apr 30, 2023
|
|
||
| futures_lite::pin!(f); | ||
| // SAFETY: We don't move the future after we pin it here. | ||
| let future = unsafe { Pin::new_unchecked(&mut f) }; |
Collaborator
There was a problem hiding this comment.
I strongly recommend that you use the same variable names here. Otherwise, it is very easy to access the owned value incorrectly.
Simple shadowing is not sufficient to prevent misuse, but in this case it is fine because it is on the outermost scope. (This is a common oversight, I sometimes see crates make the false claim that simple shadowing is "doing the exact same thing as pin_mut".)
Well, it would be better to duplicate the pin macro as you have done for the ready macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't really use much from
futures-lite, butfutures-liteballoons our dependency count significantly. This PR inlines what we do use fromfutures-lite.