Skip to content

Update to windows-sys 0.60 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2025
Merged

Update to windows-sys 0.60 #230

merged 2 commits into from
Jul 19, 2025

Conversation

zeenix
Copy link
Member

@zeenix zeenix commented Jun 13, 2025 •
edited by taiki-e
Loading

Closes #231

@zeenix
Copy link
Member Author

zeenix commented Jun 13, 2025

Hmm.. seems it requires bumping MSRV to 1.65. @taiki-e what's our MSRV policy again?

@taiki-e
Copy link
Collaborator

taiki-e commented Jun 13, 2025

error: package tracing-core v0.1.34 cannot be built because it requires rustc 1.65.0 or newer, while the currently active rustc version is 1.63.0

I think tracing dependency should be optional.
That is what we did in the past in blocking (smol-rs/blocking#60) and what we are trying to do now in polling (smol-rs/polling#231).

@taiki-e taiki-e mentioned this pull request Jun 22, 2025
Merged
@taiki-e taiki-e mentioned this pull request Jul 6, 2025
Merged
@taiki-e taiki-e merged commit 3105382 into smol-rs:master Jul 19, 2025
24 checks passed
This was referenced Jul 19, 2025
Closed
Merged
@zeenix zeenix deleted the upgrade-windows-sys branch July 19, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeenix @taiki-e