Skip to content

chore: generate default endpoint ruleset #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

chore: generate default endpoint ruleset #1589

merged 1 commit into from
May 13, 2025

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented May 12, 2025

Generates a default endpoint ruleset to make code generation consistent between service models that do and don't provide a ruleset trait.

@kuhe kuhe requested a review from a team as a code owner May 12, 2025 20:55
@kuhe kuhe force-pushed the feat/default-ruleset branch from 1b8bf47 to d3645b6 Compare May 12, 2025 20:56
@kuhe kuhe changed the title feat: generate default endpoint ruleset chore: generate default endpoint ruleset May 12, 2025
@@ -249,15 +257,16 @@ export class RpcV2ProtocolClient extends __Client<
let _config_0 = __getRuntimeConfig(configuration || {});
super(_config_0 as any);
this.initConfig = _config_0;
let _config_1 = resolveCustomEndpointsConfig(_config_0);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main point of the change is here. The deprecated resolveCustomEndpointsConfig input interface requires a user-supplied endpoint. Equivalent functionality will be provided by the default endpointRuleSet.

@kuhe kuhe merged commit 786dd3a into main May 13, 2025
10 checks passed
@kuhe kuhe deleted the feat/default-ruleset branch May 13, 2025 15:57
kuhe added a commit to kuhe/smithy-typescript that referenced this pull request May 14, 2025
@kuhe kuhe mentioned this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants