Restore warnings in CI #4122
Description
Warnings have been temporarily disabled as part of MSRV bump in #4120. Places that need to restore warnings are annotated with TODO(MSRV1.82 follow-up).
While TODO comments state the warnings came from server crates, others do come from the client crates.
Warnings in client runtime crates (fixed in #4126)
- check-aws-config
error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/meta/credentials/chain.rs:126:13
|
126 | / match provider.fallback_on_interrupt() {
127 | | creds @ Some(_) => return creds,
128 | | None => {}
129 | | }
| |_____________^ help: try: `if let creds @ Some(_) = provider.fallback_on_interrupt() { return creds }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `-D clippy::single-match` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_match)]`
- check-aws-sdk-smoketest-docs-clippy-udeps
warning: unclosed HTML tag `code`
--> sdk/kms/src/client/create_custom_key_store.rs:11:1569
|
11 | ...yphens (<code>-</code>). Additional slashes (<code>/</code> and <code>\</code>) are not permitted.</p> <p><b>Uniqueness requirements: ...
| ^^^^^^
|
= note: `#[warn(rustdoc::invalid_html_tags)]` on by default
Documenting aws-sdk-route53 v0.0.0-local (/home/build/workspace/aws-sdk-smoketest/sdk/route53)
Documenting aws-sdk-dynamodb v0.0.0-local (/home/build/workspace/aws-sdk-smoketest/sdk/dynamodb)
warning: invalid self-closing HTML tag `bucketloggingstatus`
--> sdk/s3/src/operation/put_bucket_logging/builders.rs:69:14
|
69 | /// <p><code><bucketloggingstatus xmlns="http://doc.s3.amazonaws.com/2006-03-01" /></code></p>
| ^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(rustdoc::invalid_html_tags)]` on by default
error: the `Err`-variant returned from this function is very large
--> sdk/aws-sigv4/src/http_request/canonical_request.rs:104:46
|
78 | Headers(HeaderValues<'a>),
| ------------------------- the variant `Headers` contains at least 128 bytes
79 | QueryParams(QueryParamValues<'a>),
| --------------------------------- the largest variant contains at least 192 bytes
...
104 | pub(crate) fn into_query_params(self) -> Result<QueryParamValues<'a>, Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `http_request::canonical_request::SignatureValues<'a>`, for example by boxing large elements or replacing it with `Box<http_request::canonical_request::SignatureValues<'a>>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
= note: `-D clippy::result-large-err` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::result_large_err)]`
Warnings in server runtime crates
- check-server-codegen-integration-tests
error: redundant closure
--> json_rpc11/rust-server-codegen/src/input.rs:963:17
|
963 | |v| crate::constrained::MaybeConstrained::Constrained(v),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `crate::constrained::MaybeConstrained::Constrained`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
- check-server-codegen-integration-tests-python
error: redundant closure
--> rest_json/rust-server-codegen-python/src/model.rs:3103:21
|
3103 | || ::std::vec::Vec::new(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `::std::vec::Vec::new`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
- check-rust-runtimes
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item
--> aws-smithy-http-server-python/src/util/collection.rs:66:9
|
66 | #[pyo3::pymethods]
| ^-----------------
| |
| move the `impl` block outside of this method `__setitem__` and up 2 bodies
|
::: aws-smithy-http-server-python/src/middleware/header_map.rs:93:28
|
93 | mutable_mapping_pymethods!(PyHeaderMap, keys_iter: PyHeaderMapKeys);
| -------------------------------------------------------------------
| | |
| | `PyHeaderMap` is not local
| in this macro invocation
|
= note: the attribute macro `pyo3::pymethods` defines the non-local `impl`, and may need to be changed
= note: the attribute macro `pyo3::pymethods` may come from an old version of the `pyo3_macros` crate, try updating your dependency with `cargo update -p pyo3_macros`
= note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl`
= note: `-D non-local-definitions` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(non_local_definitions)]`
= note: this error originates in the attribute macro `pyo3::pymethods` which comes from the expansion of the macro `mutable_mapping_pymethods` (in Nightly builds, run with -Z macro-backtrace for more info)
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item
--> aws-smithy-http-server-python/src/util/collection.rs:66:9
error: unexpected `cfg` condition name: `addr_of`
--> aws-smithy-http-server-python/src/error.rs:30:1
|
30 | create_exception!(smithy, PyException, BasePyException);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: expected names are: `docsrs`, `feature`, and `test` and 31 more
= note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate
= help: try referring to `$crate::pyobject_native_type_info` crate for guidance on how handle this unexpected cfg
= help: the macro `$crate::pyobject_native_type_info` may come from an old version of the `pyo3` crate, try updating your dependency with `cargo update -p pyo3`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `-D unexpected-cfgs` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`