Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Mar 27, 2023

This pull request resolves #1129

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client labels Mar 27, 2023
@seratch seratch added this to the 1.28.1 milestone Mar 27, 2023
@seratch seratch self-assigned this Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #1133 (7592445) into main (dc788dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1133   +/-   ##
=========================================
  Coverage     75.75%   75.75%           
- Complexity     3812     3816    +4     
=========================================
  Files           414      414           
  Lines         11866    11867    +1     
  Branches       1174     1178    +4     
=========================================
+ Hits           8989     8990    +1     
+ Misses         2172     2171    -1     
- Partials        705      706    +1     
Impacted Files Coverage Δ
...ain/java/com/slack/api/util/http/ProxyUrlUtil.java 86.66% <100.00%> (+0.45%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit bba0fe4 into slackapi:main Mar 27, 2023
@seratch seratch deleted the issue-1129-schema-less-proxy branch March 27, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting schema-less URL for proxy URLs results in NullPointerException

1 participant