- 
                Notifications
    You must be signed in to change notification settings 
- Fork 11
feat: add client.chat_stream helper #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇🏻 Thanks so much for putting up this PR!
📝 Quick change request is that we'll need to also update the chat_startStream references in listeners/events/app_mentioned.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Thanks for putting together this PR! 🎉
🧪 Manual testing working for DM, mentions, and assistant threads.
| # Loop over OpenAI response stream | ||
| # https://platform.openai.com/docs/api-reference/responses/create | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added commit 15d6bce to keep the comments consistent between the assistant and app_mention files.
| streamer = client.chat_stream( | ||
| channel=channel_id, | ||
| recipient_team_id=team_id, | ||
| recipient_user_id=user_id, | ||
| thread_ts=thread_ts, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Thanks @srtaalej for improving this formatting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type of change
Summary
adds new streaming helper
Requirements