Skip to content

Conversation

@srtaalej
Copy link
Contributor

@srtaalej srtaalej commented Oct 2, 2025

Type of change

  • New feature
  • Bug fix
  • Documentation

Summary

adds new streaming helper

Requirements

  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@srtaalej srtaalej requested a review from mwbrooks October 2, 2025 20:03
@mwbrooks mwbrooks changed the title feat: streaming helper feat: add chat_stream helper Oct 2, 2025
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏻 Thanks so much for putting up this PR!

📝 Quick change request is that we'll need to also update the chat_startStream references in listeners/events/app_mentioned.py

@mwbrooks mwbrooks changed the title feat: add chat_stream helper feat: add client.chat_stream helper Oct 2, 2025
@mwbrooks mwbrooks requested a review from zimeg October 2, 2025 20:22
@mwbrooks mwbrooks added the enhancement New feature or request label Oct 2, 2025
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks for putting together this PR! 🎉

🧪 Manual testing working for DM, mentions, and assistant threads.

Comment on lines +128 to +129
# Loop over OpenAI response stream
# https://platform.openai.com/docs/api-reference/responses/create
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added commit 15d6bce to keep the comments consistent between the assistant and app_mention files.

Comment on lines +37 to +41
streamer = client.chat_stream(
channel=channel_id,
recipient_team_id=team_id,
recipient_user_id=user_id,
thread_ts=thread_ts,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks @srtaalej for improving this formatting!

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srtaalej @mwbrooks LGTM! This is a neat change to find from testing! 🚢 💨

@srtaalej srtaalej merged commit 9e88bce into ai-apps Oct 3, 2025
3 checks passed
@srtaalej srtaalej deleted the ale-ai-apps-stream-helper branch October 3, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants