Skip to content

Remove pytest.ini to remove test warning #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zpoint
Copy link
Collaborator

@zpoint zpoint commented Apr 26, 2025

We got many warning when running pytest now:

Its likely introduced by pytest.ini from #5328

We use pyproject.toml for pytest option before, and the same config already added in #5348

These two might have conflict.

======================================================================= warnings summary =======================================================================
--
  | tests/smoke_tests/test_basic.py:74
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:74: DeprecationWarning: invalid escape sequence '\$'
  | f'sky exec {name} "prlimit -n --pid=\$(pgrep -f \'raylet/raylet --raylet_socket_name\') \| grep \'"\'1048576 1048576\'"\'"',
  |  
  | tests/smoke_tests/smoke_tests_utils.py:335
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/smoke_tests_utils.py:335: DeprecationWarning: invalid escape sequence '\.'
  | ' \| grep -q "eks\.amazonaws\.com"'
  |  
  | tests/smoke_tests/test_basic.py:43
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:43: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast  #requires GCP and AWS set up
  |  
  | tests/smoke_tests/test_basic.py:44
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:44: PytestUnknownMarkWarning: Unknown pytest.mark.no_fluidstack - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_fluidstack  #requires GCP and AWS set up
  |  
  | tests/smoke_tests/test_basic.py:129
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:129: PytestUnknownMarkWarning: Unknown pytest.mark.no_fluidstack - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_fluidstack
  |  
  | tests/smoke_tests/test_basic.py:130
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:130: PytestUnknownMarkWarning: Unknown pytest.mark.no_lambda_cloud - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_lambda_cloud
  |  
  | tests/smoke_tests/test_basic.py:131
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:131: PytestUnknownMarkWarning: Unknown pytest.mark.no_ibm - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_ibm
  |  
  | tests/smoke_tests/test_basic.py:132
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:132: PytestUnknownMarkWarning: Unknown pytest.mark.no_kubernetes - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_kubernetes
  |  
  | tests/smoke_tests/test_basic.py:204
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:204: PytestUnknownMarkWarning: Unknown pytest.mark.no_fluidstack - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_fluidstack  # FluidStack does not support stopping instances in SkyPilot implementation
  |  
  | tests/smoke_tests/test_basic.py:205
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:205: PytestUnknownMarkWarning: Unknown pytest.mark.no_lambda_cloud - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_lambda_cloud  # Lambda Cloud does not support stopping instances
  |  
  | tests/smoke_tests/test_basic.py:206
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:206: PytestUnknownMarkWarning: Unknown pytest.mark.no_kubernetes - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_kubernetes  # Kubernetes does not support stopping instances
  |  
  | tests/smoke_tests/test_basic.py:207
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:207: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast  # This requires port opening
  |  
  | tests/smoke_tests/test_basic.py:229
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:229: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast
  |  
  | tests/smoke_tests/test_basic.py:271
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:271: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast
  |  
  | tests/smoke_tests/test_basic.py:308
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:308: PytestUnknownMarkWarning: Unknown pytest.mark.no_fluidstack - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_fluidstack  # Requires amazon S3
  |  
  | tests/smoke_tests/test_basic.py:309
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:309: PytestUnknownMarkWarning: Unknown pytest.mark.no_scp - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_scp  # SCP does not support num_nodes > 1 yet
  |  
  | tests/smoke_tests/test_basic.py:310
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:310: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast  # Vast does not support num_nodes > 1 yet
  |  
  | tests/smoke_tests/test_basic.py:331
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:331: PytestUnknownMarkWarning: Unknown pytest.mark.no_scp - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_scp  # SCP does not support num_nodes > 1 yet. Run test_scp_logs instead.
  |  
  | tests/smoke_tests/test_basic.py:332
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:332: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast  # Vast does not support num_nodes > 1 yet.
  |  
  | tests/smoke_tests/test_basic.py:417
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:417: PytestUnknownMarkWarning: Unknown pytest.mark.no_kubernetes - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_kubernetes
  |  
  | tests/smoke_tests/test_basic.py:533
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:533: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast  # Vast has low availability for K80 GPUs
  |  
  | tests/smoke_tests/test_basic.py:534
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:534: PytestUnknownMarkWarning: Unknown pytest.mark.no_fluidstack - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_fluidstack  # Fluidstack does not support K80 gpus for now
  |  
  | tests/smoke_tests/test_basic.py:535
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:535: PytestUnknownMarkWarning: Unknown pytest.mark.no_paperspace - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_paperspace  # Paperspace does not support K80 gpus
  |  
  | tests/smoke_tests/test_basic.py:536
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:536: PytestUnknownMarkWarning: Unknown pytest.mark.no_nebius - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_nebius  # Nebius does not support K80s
  |  
  | tests/smoke_tests/test_basic.py:551
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:551: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast  # Vast has low availability for T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:552
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:552: PytestUnknownMarkWarning: Unknown pytest.mark.no_fluidstack - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_fluidstack  # Fluidstack has low availability for T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:553
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:553: PytestUnknownMarkWarning: Unknown pytest.mark.no_paperspace - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_paperspace  # Paperspace does not support T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:554
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:554: PytestUnknownMarkWarning: Unknown pytest.mark.no_nebius - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_nebius  # Nebius does not support T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:569
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:569: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast  # Vast has low availability for T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:570
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:570: PytestUnknownMarkWarning: Unknown pytest.mark.no_fluidstack - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_fluidstack  # Fluidstack has low availability for T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:571
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:571: PytestUnknownMarkWarning: Unknown pytest.mark.no_paperspace - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_paperspace  # Paperspace does not support T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:572
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:572: PytestUnknownMarkWarning: Unknown pytest.mark.no_nebius - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_nebius  # Nebius does not support T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:586
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:586: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast  # Vast has low availability for T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:587
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:587: PytestUnknownMarkWarning: Unknown pytest.mark.no_fluidstack - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_fluidstack  # Fluidstack has low availability for T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:588
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:588: PytestUnknownMarkWarning: Unknown pytest.mark.no_paperspace - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_paperspace  # Paperspace does not support T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:589
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:589: PytestUnknownMarkWarning: Unknown pytest.mark.no_nebius - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_nebius  # Nebius does not support T4 GPUs
  |  
  | tests/smoke_tests/test_basic.py:604
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:604: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast  # Requires other clouds to be enabled
  |  
  | tests/smoke_tests/test_basic.py:605
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:605: PytestUnknownMarkWarning: Unknown pytest.mark.no_fluidstack - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_fluidstack  # Requires other clouds to be enabled
  |  
  | tests/smoke_tests/test_basic.py:621
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:621: PytestUnknownMarkWarning: Unknown pytest.mark.no_fluidstack - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_fluidstack  # Requires other clouds to be enabled
  |  
  | tests/smoke_tests/test_basic.py:622
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:622: PytestUnknownMarkWarning: Unknown pytest.mark.no_vast - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_vast  # Requires other clouds to be enabled
  |  
  | tests/smoke_tests/test_basic.py:623
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:623: PytestUnknownMarkWarning: Unknown pytest.mark.no_paperspace - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_paperspace  # Requires other clouds to be enabled
  |  
  | tests/smoke_tests/test_basic.py:624
  | /home/buildkite/.buildkite-agent/builds/generic_cloud/993bc8ec23b2-1/skypilot-1/smoke-tests/tests/smoke_tests/test_basic.py:624: PytestUnknownMarkWarning: Unknown pytest.mark.no_kubernetes - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
  | @pytest.mark.no_kubernetes
  |  
  | -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • /smoke-test --aws -k test_core_api_sky_launch_fast

@zpoint
Copy link
Collaborator Author

zpoint commented Apr 26, 2025

/smoke-test --gcp -k test_gcp_disk_tier

@zpoint zpoint marked this pull request as draft April 26, 2025 07:47
@zpoint zpoint changed the title Remove test warning and failure Remove test warning Apr 26, 2025
@zpoint zpoint changed the title Remove test warning Remove pytest.ini to remove test warning Apr 26, 2025
@zpoint
Copy link
Collaborator Author

zpoint commented Apr 26, 2025

/smoke-test --aws -k test_core_api_sky_launch_fast

@zpoint
Copy link
Collaborator Author

zpoint commented Apr 26, 2025

The gcp failure is not related, see #5380

@zpoint
Copy link
Collaborator Author

zpoint commented Apr 26, 2025

The new test do not have thoese warnings

@zpoint zpoint marked this pull request as ready for review April 26, 2025 08:36
@zpoint zpoint requested review from aylei and cg505 April 26, 2025 08:36
@zpoint
Copy link
Collaborator Author

zpoint commented Apr 27, 2025

/smoke-test --aws -k test_core_api_sky_launch_fast

Copy link
Collaborator

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this! @zpoint

@aylei aylei merged commit 966b4b5 into skypilot-org:master Apr 27, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants