-
Notifications
You must be signed in to change notification settings - Fork 716
[k8s] Fix show-gpus when limited permissions are available #4208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
UX: |
|
<no permissions> sounds good.
…On Tue, Nov 5, 2024 at 11:52 AM Romil Bhardwaj ***@***.***> wrote:
<insufficient permissions> might be too long... how about <no permissions>?
Or even <forbidden>?
—
Reply to this email directly, view it on GitHub
<#4208 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEQWHWBJNM6ONYUUHJFHOTZ7EOW5AVCNFSM6AAAAABQ3CREZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJYGAZTENJSGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Updated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @romilbhardwaj! LGTM.
resources: # Custom resource requests and limits | ||
requests: | ||
rdma/rdma_shared_device_a: 1 | ||
limits: | ||
rdma/rdma_shared_device_a: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this relates to the show-gpus
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, just adding docs on how to add custom resources through pod_config. Could have been a separate PR :)
Updates our minimal permissions doc to add permissions required by show-gpus, and updates show-gpus to work with limited permissions:
Also adds a quick snippet for specifying custom resources in pod_config.