Skip to content

Add an option for user to retrieve recent submission in certain programming language #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add an option for user to retrieve recent submission in certain programming language #33

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ebf5933
Add an option -l for submission command which allows user to retrive …
Jun 1, 2017
2f083f4
change behavior: when user specify a language and there are no accept…
Jun 1, 2017
7150f97
bug-fix: problem state is related to the latest submission regardless…
Jun 1, 2017
3affd04
change behavior: when user specify a language and there are no accept…
Jun 1, 2017
99f4e02
Merge branch 'master' of https://github.com/timle1029/leetcode-cli
Jun 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions lib/commands/submission.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ var cmd = {
type: 'boolean',
default: false,
describe: 'Provide extra problem details in submission file'
},
lang: {
alias: 'l',
type: 'string',
default: 'all',
describe: 'Programming language used for previous submission'
}
}
};
Expand Down Expand Up @@ -68,21 +74,31 @@ function exportSubmission(argv, problem, cb) {
if (e) return cb(e);
if (submissions.length === 0) return cb('no submissions?');

// find the latest accepted one
var submission = _.find(submissions, function(x) {
// TODO: select by lang?
// get obj list contain required filetype
var submissionInTargetType = _.filter(submissions, function(x) {
if (argv.lang === 'all') {
return true;
}
return argv.lang === x.lang;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use one line to do the same:

return argv.lang === 'all' || argv.lang === x.lang;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggestion! I'll replace them with this one line statement.
I'm sorry that I might mess up this pull request with too many commits, seems that I made a mistake during rebase. I would like to close this PR and make a new PR with one commit.
Sorry for the inconvenience.

});
if (submissionInTargetType.length === 0) {
return cb("No previous submission in required language.");
}
var submission = _.find(submissionInTargetType, function(x) {
return x.status_display === 'Accepted';
});

var submissionState = submission === undefined ? 'notac' : 'ac';

// if no accepted, use the latest non-accepted one
submission = submission || submissions[0];
submission = submission || submissionInTargetType[0];

var filename = sprintf('%s/%d.%s.%s.%s%s',
argv.outdir,
problem.id,
problem.key,
submission.id,
problem.state,
submissionState,
h.langToExt(submission.lang));

// skip the existing cached submissions
Expand Down