Add an option for user to retrieve recent submission in certain programming language #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lejiati
commented
Jun 1, 2017
lejiati
commented
- Add an option for user to get a previous submission in a certain language.
- Change one behavior: when user chose a language and there are no accepted submission, program returns the most non accepted submission in this language rather than the "global" recent.
- Fix bug: When user select a language and the most submission in this language is accepted while the "global" latest submission is not accepted, the program will create an accepted copy with 'notac' in filename.
added 3 commits
May 31, 2017 22:39
…recent submission in requried programming language, if no submissino in required language, an error will be printed. If no language is specified, program will retrive retrive most recent accepted submission.
…ed submission, program will return the most recent non accepted submission in this language
… which language we use. When user specified a language, the status should be related to the latest submission in this language rather than problem
|
@timle1029 Thanks for pulling. Could you please merge those 3 patches into single one? basically you can use |
skygragon
reviewed
Jun 1, 2017
lib/commands/submission.js
Outdated
| if (argv.lang === 'all') { | ||
| return true; | ||
| } | ||
| return argv.lang === x.lang; |
There was a problem hiding this comment.
could use one line to do the same:
return argv.lang === 'all' || argv.lang === x.lang;
There was a problem hiding this comment.
Thanks for suggestion! I'll replace them with this one line statement.
I'm sorry that I might mess up this pull request with too many commits, seems that I made a mistake during rebase. I would like to close this PR and make a new PR with one commit.
Sorry for the inconvenience.
added 2 commits
June 1, 2017 01:25
…ed submission, program will return the most recent non accepted submission in this language (+2 squashed commits) Squashed commits: [7150f97] bug-fix: problem state is related to the latest submission regardless which language we use. When user specified a language, the status should be related to the latest submission in this language rather than problem [6fdb72f] simplify code
tainenko
pushed a commit
to tainenko/leetcode-cli
that referenced
this pull request
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.