Skip to content

Conversation

@DD3Boh
Copy link
Contributor

@DD3Boh DD3Boh commented Jan 16, 2025

  • Switch to using the vector based in for the launcher
  • Add support for the monochrome icon in the launcher
  • Remove unneeded android:roundIcon property

@88250
Copy link
Member

88250 commented Jan 16, 2025

If the sizes are inconsistent, an overlay will occur during the loading process:

fedd813f7309103748ad35ce6f6b869d

@DD3Boh
Copy link
Contributor Author

DD3Boh commented Jan 16, 2025

I will keep the PNG icon just for the loading screen then? It's better to have the monochrome and regular icon be identical for the launcher icon in my opinion, since that means the size is the same in both modalities.

@88250
Copy link
Member

88250 commented Jan 16, 2025

Well, let’s use pictures for the loading interface.

@DD3Boh
Copy link
Contributor Author

DD3Boh commented Jan 16, 2025

Ok, I did some testing around this on my Pixel 9. Can you check if you had this issue earlier too on debug builds? (without my changes)

I have tested multiple times now and I can confirm that I had this bug before as well, and I also have it with stable builds. The difference with stable builds is that the build itself is faster, which means that this bug occurs only on the very first launch of the application (right after you format the application data) and not in the other ones.
On debug builds instead, this happens consistently because the launch is slower.

@DD3Boh DD3Boh force-pushed the feature/icon-update branch from 26b78d3 to bbe404b Compare January 16, 2025 15:40
@DD3Boh
Copy link
Contributor Author

DD3Boh commented Jan 16, 2025

Here's the version keeping the icon.png everywhere except for the launcher icon which uses the svg. I still have the bug on one of my devices but it's unrelated from this PR.
I don't have the same glitch on another device of mine, not sure what the culprit is.
But the PR itself is fine and doesn't break anything from what I'm seeing.

@88250
Copy link
Member

88250 commented Jan 17, 2025

The previous version I tested here did not have this problem, but this problem may be affected by the screen resolution/size, and I cannot reproduce it here.

At present, the modification of PR is ready. We will ignore the previous problems for now. Maybe we can solve them in the future. Thank you for your contribution.

@88250 88250 merged commit 53ec163 into siyuan-note:main Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants