Skip to content

Use the underscore name description_file in setup.cfg instead of deprecated description-file #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
edgarrmondragon wants to merge 1 commit into from
Closed

Use the underscore name description_file in setup.cfg instead of deprecated description-file #170

edgarrmondragon wants to merge 1 commit into from

Conversation

@edgarrmondragon
Copy link

@edgarrmondragon edgarrmondragon commented Mar 24, 2025 •
edited
Loading

Description of change

setuptools recently made a breaking change:

Manual QA steps

virtualenv .venv
source .venv/bin/activate
pip install -e .

Risks

  • Maybe some folks get a really old (~2021) setuptools installed in their toolchain and this breaks them? Haven't confirmed yet.

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@edgarrmondragon edgarrmondragon mentioned this pull request Mar 24, 2025
Open
@edgarrmondragon
Copy link
Author

edgarrmondragon commented Mar 25, 2025

Done in #171 by @bryantgray. Thanks!

@edgarrmondragon edgarrmondragon deleted the edgarrmondragon-patch-1 branch March 25, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@edgarrmondragon