Add type definition tests #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamVerschueren
force-pushed
the
tsd-check
branch
from
058056b to
e65db4e
Compare
SamVerschueren
commented
Aug 29, 2018
| @@ -39,6 +39,7 @@ export interface Options { | |||
| * Creates directories for you as needed. | |||
| * | |||
| * @example | |||
| * | |||
There was a problem hiding this comment.
This is needed because of a rendering issue. We can remove it though. Eventually it will be fixed (probably). microsoft/TypeScript#15749
There was a problem hiding this comment.
That is so weird 🤔
I was wondering why the @example didn't look good, makes sense now
| import {expectType} from 'tsd-check'; | ||
| import writeJsonFile, {sync, Replacer, SortKeys, JSONStringifyable} from '.'; | ||
|
|
||
| (async () => { |
There was a problem hiding this comment.
@SamVerschueren This must be the most intense Typescript test I've ever seen 😮
Good job! 👍
|
Very thorough. Great work as always, Sam. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for the type definitions. While I was working on them, I also noticed that some things where missing/wrong in the typings.