Allow changing intervalCap later
#233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a test for when toggling infinite to finite mid-interval.
|
sindresorhus
requested changes
Sep 30, 2025
| return this.#intervalCount; | ||
| } | ||
|
|
||
| set intervalCap(value: number) { |
There was a problem hiding this comment.
Removing the cap mid-interval must claer ratelimit state. When setting intervalCap = Number.POSITIVE_INFINITY, you switch to “interval ignored.” You do call #processQueue(), but if #rateLimitedInInterval or #rateLimitFlushScheduled are set, they can still throttle execution until the old timeout fires. Reset those flags when the cap becomes infinite, then process.
|
|
||
| The max number of runs in the given interval of time. | ||
|
|
||
| Can be changed later by setting `queue.intervalCap`. If changed in the middle of a running interval, the new cap applies immediately. If the new cap is lower than the used cap, the "debt" is not carried over into the next interval. |
There was a problem hiding this comment.
"Debt is not carried over into the next interval" is bit unclear. Say exactly what happens:
If the new cap is lower than the number already run in the current interval, no more tasks start until the next interval begins.
Co-Authored-By: Sindre Sorhus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#177