Skip to content

Refactor TypeScript definition to CommonJS compatible export #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 6, 2019
Merged

Refactor TypeScript definition to CommonJS compatible export #17

merged 3 commits into from
Apr 6, 2019

Conversation

BendingBender
Copy link
Contributor

No description provided.

@BendingBender
Copy link
Contributor Author

BendingBender commented Apr 6, 2019 •
edited
Loading

@sindresorhus The type change to any is necessary so that the types work under strictFunctionTypes compiler option. I think it's worth it to write the types in the most compatible way for users to consume.

@BendingBender BendingBender mentioned this pull request Apr 6, 2019
Merged
@sindresorhus
Copy link
Owner

Ah ok. I thought it was just an oversight.

@sindresorhus sindresorhus merged commit 52a012a into sindresorhus:master Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BendingBender @sindresorhus