Issue 98 - Handle undefined content type header when evaluating visibility #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khlr
approved these changes
Apr 11, 2025
Contributor
|
Thanks for finding and fixing that bug 😊 |
Member
|
@khlr are you releasing this? Seems like a big enough bug to justify a new release (especially given our release-cycle).. |
Contributor
|
@tvdijen yep I plan to do so by the end of the next week. |
Member
|
Agreed! No immediate rush, I was just thinking out loud! |
Contributor
Author
|
@khlr Thank you for approving this and getting it in so quickly! Could you please @ me when it makes it into the Chrome web store? I can't give my workaround to customers, and need it almost daily for exporting traces. |
Contributor
|
Yep, I'll do so 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change, which handles the case where contentTypeHeader is undefined in isRequestVisible (which it often is in my use case), fixes issue 98, the export problem. It also eliminates a bunch of unhandled exception cases in the console.