Skip to content

Conversation

@khlr
Copy link
Contributor

@khlr khlr commented Oct 5, 2018

There's a bug which leads to trace records of resources being filtered even if the Filter resources button is deactivated.

This happens because the CSS class displayAnyway isn't appended to a resource-request in the attachResponseToRequest function. Only a click on Filter resources adds the class to the resource-requests.

The correct behavior would be to add the class directly within attachResponseToRequest function if the current state of filterResources is false.


Current behavior in SAML-tracer v1.5.1
Notice the filtered requests even though the filter button is not active:

73125401-20c6-4132-a07c-191cb45037b7

This pull request corrects the behavior as shown beneath

714ef735-5785-4290-bf15-4b8e66eea19f

… the current state of `filterResources` is false.
@jaimeperez jaimeperez merged commit c3ef7df into simplesamlphp:master Oct 9, 2018
@jaimeperez
Copy link
Member

Thanks a lot @khlr!

@khlr khlr deleted the bugfix/show-resources-if-filter-not-active branch October 9, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants