Functionality for filtering for protocol-related requests only #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdijen
reviewed
Apr 16, 2025
| case 'application/font-woff2': | ||
| case 'application/x-font-ttf': | ||
| case 'application/x-font-woff': | ||
| case 'font/woff2': |
Member
There was a problem hiding this comment.
This one should already be filtered by the case on line 612/616
Contributor
Author
There was a problem hiding this comment.
You're absolutely right. Can't tell why I thought, this'd be required. I'll revert it.
Member
|
Code looks fine! Haven't tested it yet |
thijskh
approved these changes
Apr 22, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves issue #97.
While making these changes I realized that I created quite bunch of spaghetti code when I converted the web extension some years ago... 🙈 And I'm afraid by adding a second filter criteria I even added some noodles...
If I had more time, I'd be itching to rewrite the whole thing properly typed with TypeScript... But that's not very realistic due to the said lack of time 😄
Any way... As the PR changes a couple of lines and some logic I'd be glad if someone would find the time to test the changes. In particular, the export and import logic with and without activated filters. Before the release of a new version, I would feel better if it wasn't just me who had done a bit of testing.
BTW, some info what has changed in the UI:
The former button Filter resources is now called Hide resources which is a better term, I think, as it better describes that the filter is exclusive. And there's now the new button Show protocol requests only which is not enabled by default.