Fix CRLF line endings correctly when preparing text for insertion #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/Runestone/TextView/Core/TextView.swift
…c with actual first responder status. Make it a computed property based on window's firstResponder variable instead. Set needs layout flag whenever becoming or resigning first responder. Update TextView isEditing status whenever isEditable changes and TextView is already first responder.
…t is available everywhere. Move updating editing state when editable status changes to TextViewController for consistency.
…Panel that shows search UI.
…earch highlights to 200. Check current search operation state in main queue. Refresh find panel state when text changes by editing and when setState is used to update text.
…he panel can remove highlights from text view.
…nsertion to highlighted ranges which has a side effect.
…ted range. Increase maximum count of visible highlights to 1000.
…s to recent searches.
# Conflicts: # Example/Example.xcodeproj/project.pbxproj # Example/iOSExample/Base.lproj/LaunchScreen.storyboard # Example/iOSExample/Main/MainViewController.swift # Package.resolved # Package.swift # Sources/Runestone/Library/L10n.swift # Sources/Runestone/TextView/Appearance/DefaultTheme.swift # Sources/Runestone/TextView/Appearance/Theme.swift # Sources/Runestone/TextView/Core/TextInputStringTokenizer.swift # Sources/Runestone/TextView/Core/TextInputView.swift # Sources/Runestone/TextView/Core/TextView.swift # Sources/Runestone/TextView/PageGuide/PageGuideView.swift # Tests/RunestoneTests/iOS/TextInputStringTokenizerTests.swift # UITests/HostUITests/KoreanInputTests.swift # UITests/HostUITests/XCUIApplication+Helpers.swift
Allow selection in non-editable text views on iOS. Update TextInputStringTokenizer. Add back text selection workarounds. Add character method to StringView. Remove lengthOfInitallyLongestLine from text views. Remove unnecessary files.
…o just search highlights. Add text color to highlighted ranges and use it when rendering text. Use corner radius for search highlights.
…lback to correct string.
…cing text in registered undo actions.
…at highlights appear at correct positions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editor was set to CRLF line endings, and pasted text already contained CRLF endings, this function would not apply line ending changes correctly. Here we first split the text separating by any kind of new line character and then join them with the correct line ending.