Skip to content

Use return $this instead of static as we're working with builders so the same instances are being returned #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

simPod
Copy link
Owner

@simPod simPod commented Feb 12, 2022

No description provided.

… so the same instances are being returned
@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #110 (fdbfbf0) into 0.5.x (b9dd8ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            0.5.x     #110   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files           9        9           
  Lines         154      154           
=======================================
  Hits          149      149           
  Misses          5        5           
Impacted Files Coverage Δ
src/Builder/EnumBuilder.php 100.00% <ø> (ø)
src/Builder/FieldBuilder.php 100.00% <ø> (ø)
src/Builder/InterfaceBuilder.php 100.00% <ø> (ø)
src/Builder/ObjectBuilder.php 100.00% <ø> (ø)
src/Builder/TypeBuilder.php 100.00% <ø> (ø)
src/Builder/UnionBuilder.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9dd8ca...fdbfbf0. Read the comment docs.

@simPod simPod merged commit c902899 into 0.5.x Feb 12, 2022
@simPod simPod deleted the return-this branch February 12, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant