Fix build error from adding "android_builtin" import. #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `addImport` on a module with no `root_source_file` causes a build error. Zig exposes a module called "root", which is the `root_source_file`, and it seems that it is expected to exist when adding imports. This makes it necessary to check if the module has a `root_source_file` before trying to add the "android_builtin" import.
Owner
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
addImporton a module with noroot_source_filecauses a build error. Zig exposes a module called "root", which is theroot_source_file, and it seems that it is expected to exist when adding imports. This makes it necessary to check if the module has aroot_source_filebefore trying to add the "android_builtin" import.