-
Notifications
You must be signed in to change notification settings - Fork 62
refactor: begin to remove sigstore_protobuf_specs #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I've published https://pypi.org/project/sigstore-models/ to accompany this. |
Okay, this is good for a review. Key changes:
Separately from the above, this PR contains some CI fixes (from |
This is great, I'll try to review tomorrow (although I don't think we need to rush with this one) |
Thanks @jku! I have an internal need for this, but there's no huge rush from me -- I can always pin to the (With that being said, I'd love it if we could land this with v4, if you think that's possible -- I think it's be nice to have a clean major break.) |
Towards #1049.
This is very WIP and won't work in CI yet since I'm using a local editable install of the newsigstore_models
package while I iterate on it.NB: I've also temporarily disabled interrogate because it has some kind of issue with a
cairo
dep.