fix(iPad): correct photo rotation in landscape mode #6086 #6089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added CameraCaptureSession.setCaptureOrientation(_:) to let callers update the underlying capture orientation on the session queue. - In PhotoCaptureViewController.viewWillAppear(_:), derive the correct interface orientation on iPad and invoke the new helper, keeping the preview layer and capture pipeline in sync. Photos and videos captured while the iPad is held in landscape now embed the correct EXIF / track orientation; no more 90-degree rotation to portrait.
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6086
Problem:
On iPadOS, in landscape mode, when taking a picture, the camera image is rotated 90° to the right. If you hold the iPad in portrait mode, the camera orientation is correct.
Expected behavior:
The camera feed and captured photo orientation should match the physical orientation of the device.
Solution:
CameraCaptureSession
setCaptureOrientation(_:), a safe helper that updatescaptureOrientationand theAVCaptureConnectionon the dedicated session queue.PhotoCaptureViewController
In
viewWillAppearwe now:UIWindowScene.interfaceOrientation(iPad-only).updateVideoPreviewConnection(to:).setCaptureOrientationso the encoder receives the same orientation.Testing:
iPad 9″ (iOS 18.3.2):
iPhone 16 pro max (iOS 18.5):
Contributor checklist