Strip media metadata. #2907
Closed
Strip media metadata. #2907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Things to test
- Orientation is preserved.
- GIF timing is preserved.
Contributor
There was a problem hiding this comment.
- Color profiles are preservd.
Author
There was a problem hiding this comment.
Hi! I just re-tested that the color space and profile, as well as orientation is preserved.
After stripping the data, these fields are left, for example:
([{TIFF}: {
Orientation = 1;
ResolutionUnit = 2;
XResolution = 72;
YResolution = 72;
}, PixelWidth: 3264, {Exif}: {
ColorSpace = 1;
PixelXDimension = 3264;
PixelYDimension = 2448;
}, PixelHeight: 2448, {JFIF}: {
DensityUnit = 0;
JFIFVersion = (
1,
0,
1
);
XDensity = 72;
YDensity = 72;
}, ProfileName: sRGB IEC61966-2.1, DPIWidth: 72, DPIHeight: 72, ColorModel: RGB, Orientation: 1, Depth: 8])
Timing looks good even with the iOS 11 live photo "GIF" movies that can be sent.
Contributor
|
Hey @collinstuart - we had a rather large release backlogged, but now that it's out, we'd like to test this and get it merged. Can you rebase? |
Author
|
@michaelkirk - sure, I should be able to get to that today! |
- removes non-orientation metadata from image and video attachments - option to disable the feature // FREEBIE
ghost
force-pushed
the
collinstuart/strip-exif-data
branch
from
657dbde to
a621133
Compare
Author
|
@michaelkirk done :) |
Contributor
|
In d9b8ce2. Thanks! |
Closed
1 task
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Strips non-orientation metadata from image and video attachments, with an option to leave the metadata in. This was tested by printing out the metadata dictionaries before and after the modification, as well as checking the attachment on a secondary device to make sure the information was truly removed.
All attachments flow through the SignalAttachment class. Images flow through the imageAttachment method of that class which strips out the metadata. I noticed that the master branch has been updated so that all video attachments are piped through the compressVideoAsMp4 inside the SignalAttachment class, so removal of video metadata was implemented there.
Fixes #1984