Skip to content

Add S3 bucket name as environment variable #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2022
Merged

Add S3 bucket name as environment variable #3

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa56de0
Add S3 bucket environment variable
shiv-io Nov 19, 2022
937fd4b
Update bucket name
shiv-io Nov 19, 2022
f885418
Update PR comment
shiv-io Nov 24, 2022
96fa6f9
Update PR comment
shiv-io Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ env:
DBT_GOOGLE_BIGQUERY_KEYFILE: ./.gcloud/dbt-service-account.json
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
# TODO:
# Validation to ensure S3_BUCKET follows naming conventions
# https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html
S3_BUCKET: dbt-${{ github.ref_name }}-bucket

jobs:
build:
Expand Down Expand Up @@ -53,28 +57,26 @@ jobs:
run: |
aws s3api create-bucket \
--acl public-read \
--bucket ${{ github.ref_name }}
--bucket $S3_BUCKET
- name: Copy to S3 bucket
run: |
aws s3 cp ./docs s3://${{ github.ref_name }} --recursive
aws s3 cp ./docs s3://$S3_BUCKET --recursive
- name: Host bucket as static website
run: |
aws s3 website \
s3://${{ github.ref_name }} \
s3://$S3_BUCKET \
--index-document index.html
- name: Add S3 bucket policy for public access
env:
S3_BUCKET: ${{ github.ref_name }}
run: |
python update_policy.py
aws s3api put-bucket-policy --bucket ${{ github.ref_name }} \
aws s3api put-bucket-policy --bucket $S3_BUCKET \
--policy file://policy_updated.json
- name: Comment on PR
uses: unsplash/comment-on-pr@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
msg: >
[dbt docs site - ${{ github.ref_name }}](https://${{ github.ref_name }}.s3.amazonaws.com/index.html) deployed!
[dbt docs site - ${{ env.S3_BUCKET }}](https://${{ env.S3_BUCKET }}.s3.amazonaws.com/index.html) deployed!
if: ${{ github.ref != 'refs/heads/main' }}