Fix: verify transactionId mismatch for Saman payment driver (Related to shetabit/payment#351) #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r Saman payment driver (Related to shetabit/payment#351)
| } | ||
|
|
||
| // set transaction id | ||
| $this->invoice->transactionId($response); |
Member
There was a problem hiding this comment.
please set resnum in the transaction id if it is used to verify the payment
Member
There was a problem hiding this comment.
this PR is not valid. you need to set transaction id and then return in in the purchase method and then user can rely on it to verify the payment.
Member
There was a problem hiding this comment.
you need to fix the line 86 in the purchase method instead of this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: verify transactionId mismatch for Saman payment driver (Related to shetabit/payment#351)
Description
Changed the callback function in the Saman payment driver to use
$this->invoice->getUuid()instead of$this->invoice->getTransactionId(). This ensures proper transaction verification after payment.Motivation and context
The callback function was verifying transactions using
getTransactionId(), which refers to the bank token of the invoice. However, this value is not returned in the bank's response after payment. Changing togetUuid()ensures proper verification of the transaction.Related to shetabit/payment#351
How has this been tested?
Tested on the live project by performing multiple real payment attempts. Verified that transaction verification works correctly with
getUuid()and that other parts of the system are unaffected.Screenshots (if appropriate)
Not applicable.
Types of changes
Checklist: