Polyglot removing highlighting

[jacksonludwig]

With the most recent release of polyglot, I am getting a few strange issues. I think someone else already posted about the java syntax not working, but I am getting a problem where highlighting for .vim files is not working correctly.

Here is non polyglot init.vim

And here is init.vim with polyglot

To Reproduce:
Install vim polyglot and open init.vim

[sheerun]

Could you paste your init.vim ?

[sheerun]

Also, what's your version of nvim?

[jacksonludwig]

Sorry I should have included these. I am on the latest nightly neovim and my init.vim is as follows:

" Plugin installs
call plug#begin()
Plug 'dracula/vim', { 'as': 'dracula' }
Plug 'https://github.com/gruvbox-community/gruvbox.git'
Plug 'https://github.com/arcticicestudio/nord-vim.git'
Plug 'https://github.com/tomasiser/vim-code-dark.git'

Plug 'https://github.com/tpope/vim-commentary.git'

Plug 'mhinz/vim-startify'
Plug 'vim-airline/vim-airline'
Plug 'vim-airline/vim-airline-themes'
Plug 'sheerun/vim-polyglot'
Plug 'https://github.com/sbdchd/neoformat.git'

Plug 'junegunn/fzf', { 'do': { -> fzf#install() } }
Plug 'junegunn/fzf.vim'

Plug 'nvim-treesitter/nvim-treesitter'

Plug 'neoclide/coc.nvim', {'do': 'yarn install --frozen-lockfile'}

Plug 'honza/vim-snippets'
Plug 'SirVer/ultisnips'

Plug 'lervag/vimtex'
Plug 'https://github.com/rhysd/vim-grammarous.git'
call plug#end()

" Basic
" Set undodir
set undodir=$HOME/.config/nvim/undodir
set undofile

" Highlight yank like emacs
augroup highlight_yank
    autocmd!
    autocmd TextYankPost * silent! lua require'vim.highlight'.on_yank()
augroup END

" Misc settings
let g:netrw_banner = 0
set number relativenumber
set autochdir
set clipboard+=unnamedplus
set splitright
set splitbelow

" Tab settings
set tabstop=4
set softtabstop=4
set shiftwidth=4
set smartindent
set expandtab

" Mouse
set mouse=a

" Syntax on (just in case)
syntax on

" Completion and updates
set signcolumn=yes
set completeopt=menuone,noselect,longest
set updatetime=50
set shortmess+=c

" Color fix for term
set termguicolors

" Binds
" Basic 
map <Space> <NOP>
let mapleader =" "

" Go to end of line in insert mode
inoremap <C-e> <C-o>$

" Deal with buffers like DOOM
noremap <leader>bs :w<CR>
noremap <leader>bp :bp<CR>
noremap <leader>bn :bn<CR>
noremap <leader>bk :q<CR>
" Quit like doom
noremap <leader>qq :q<CR>

" Also use C-j and C-k to scroll in menus
inoremap <expr> <C-j> pumvisible() ? "\<C-n>" : "\<C-j>"
inoremap <expr> <C-k> pumvisible() ? "\<C-p>" : "\<C-k>"

" Use <C-k> like k
noremap <c-k> k

" Remove highlight when esc is pressed
nmap <silent><ESC> :noh<CR>

" Color settings
" Colorscheme settings
colorscheme nord
highlight Comment cterm=italic gui=italic

" Misc plugin
" Startify
let g:startify_custom_header = []

" Neoformat -- formats stuff that lsp's don't
let g:neoformat_enabled_ocaml = ['ocpindent']
noremap <leader>- :Neoformat<CR>

" Airline config
" let g:airline#extensions#coc#enabled = '0'
let g:airline#extensions#tabline#enabled = 1
let g:airline#extensions#tabline#show_buffers = 0
let g:airline#extensions#tabline#show_tabs = 1
let g:airline#extensions#tabline#show_close_button = 0
let g:airline#extensions#tabline#tabs_label = ''
let g:airline#extensions#tabline#buffers_label = ''
let g:airline#extensions#tabline#fnamemod = ':t'
let g:airline#extensions#tabline#show_tab_count = 0
let g:airline#extensions#tabline#show_buffers = 0
let g:airline#extensions#tabline#show_splits = 0
let g:airline#extensions#tabline#show_tab_nr = 0
let g:airline#extensions#tabline#show_tab_type = 0
let g:airline#extensions#tabline#tab_min_count = 2
set noshowmode

" Open fzf
" files
nnoremap <silent> <leader><space> :Files<CR>
" buffers
nnoremap <silent> <leader>bb :Buffers<CR>
" history
nnoremap <silent> <leader>h :History<CR>
let g:fzf_layout = { 'window': { 'width': 0.8, 'height': 0.8 } }
let $FZF_DEFAULT_OPTS='--reverse'

" Tex tweaks
let g:tex_flavor = "latex"
let g:vimtex_view_method='zathura'
autocmd FileType tex setlocal wrap
autocmd FileType tex inoremap <buffer> . .<C-g>u
autocmd FileType tex inoremap <buffer> ! !<C-g>u
autocmd FileType tex inoremap <buffer> ? ?<C-g>u
autocmd FileType tex inoremap <buffer> : :<C-g>u

" Snippets
let g:completion_enable_snippet = 'UltiSnips'
let g:UltiSnipsExpandTrigger="<C-l>"
let g:UltiSnipsJumpForwardTrigger="<c-j>"
let g:UltiSnipsJumpBackwardTrigger="<c-k>"

" Treesitter
lua <<EOF
require "nvim-treesitter.configs".setup {
    ensure_installed = "all", -- one of "all", "language", or a list of languages
    highlight = {
        enable = true, -- false will disable the whole extension
        disable = { "lua", "bash", "latex", "json" }
    }
}
EOF

" LSP
" TextEdit might fail if hidden is not set.
set hidden

" Some servers have issues with backup files, see #649.
set nobackup
set nowritebackup

" Use tab for trigger completion with characters ahead and navigate.
" NOTE: Use command ':verbose imap <tab>' to make sure tab is not mapped by
" other plugin before putting this into your config.
inoremap <silent><expr> <TAB>
      \ pumvisible() ? "\<C-n>" :
      \ <SID>check_back_space() ? "\<TAB>" :
      \ coc#refresh()
inoremap <expr><S-TAB> pumvisible() ? "\<C-p>" : "\<C-h>"

function! s:check_back_space() abort
  let col = col('.') - 1
  return !col || getline('.')[col - 1]  =~# '\s'
endfunction

" Use <c-space> to trigger completion.
if has('nvim')
  inoremap <silent><expr> <c-space> coc#refresh()
else
  inoremap <silent><expr> <c-@> coc#refresh()
endif

" Use <cr> to confirm completion, `<C-g>u` means break undo chain at current
" position. Coc only does snippet and additional edit on confirm.
" <cr> could be remapped by other vim plugin, try `:verbose imap <CR>`.
if exists('*complete_info')
  inoremap <expr> <cr> complete_info()["selected"] != "-1" ? "\<C-y>" : "\<C-g>u\<CR>"
else
  inoremap <expr> <cr> pumvisible() ? "\<C-y>" : "\<C-g>u\<CR>"
endif

" Use `[g` and `]g` to navigate diagnostics
" Use `:CocDiagnostics` to get all diagnostics of current buffer in location list.
nmap <silent> [g <Plug>(coc-diagnostic-prev)
nmap <silent> ]g <Plug>(coc-diagnostic-next)

" GoTo code navigation.
nmap <silent> gd <Plug>(coc-definition)
nmap <silent> gy <Plug>(coc-type-definition)
nmap <silent> gi <Plug>(coc-implementation)
nmap <silent> gr <Plug>(coc-references)

" Use K to show documentation in preview window.
nnoremap <silent> K :call <SID>show_documentation()<CR>

function! s:show_documentation()
  if (index(['vim','help'], &filetype) >= 0)
    execute 'h '.expand('<cword>')
  else
    call CocActionAsync('doHover')
  endif
endfunction

" Highlight the symbol and its references when holding the cursor.
autocmd CursorHold * silent call CocActionAsync('highlight')

" Symbol renaming.
nmap <leader>rn <Plug>(coc-rename)

augroup mygroup
  autocmd!
  " Update signature help on jump placeholder.
  autocmd User CocJumpPlaceholder call CocActionAsync('showSignatureHelp')
augroup end

" Applying codeAction to the selected region.
" Example: `<leader>aap` for current paragraph
xmap <leader>a  <Plug>(coc-codeaction-selected)
nmap <leader>a  <Plug>(coc-codeaction-selected)

" Remap keys for applying codeAction to the current buffer.
nmap <leader>ac  <Plug>(coc-codeaction)
" Apply AutoFix to problem on the current line.
nmap <leader>qf  <Plug>(coc-fix-current)

" Map function and class text objects
" NOTE: Requires 'textDocument.documentSymbol' support from the language server.
xmap if <Plug>(coc-funcobj-i)
omap if <Plug>(coc-funcobj-i)
xmap af <Plug>(coc-funcobj-a)
omap af <Plug>(coc-funcobj-a)
xmap ic <Plug>(coc-classobj-i)
omap ic <Plug>(coc-classobj-i)
xmap ac <Plug>(coc-classobj-a)
omap ac <Plug>(coc-classobj-a)

" Use CTRL-S for selections ranges.
" Requires 'textDocument/selectionRange' support of language server.
nmap <silent> <C-s> <Plug>(coc-range-select)
xmap <silent> <C-s> <Plug>(coc-range-select)

" Add `:Format` command to format current buffer.
command! -nargs=0 Format :call CocAction('format')

" Add `:Fold` command to fol current buffer.
command! -nargs=? Fold :call     CocAction('fold', <f-args>)

" Add `:OR` command for organize imports of the current buffer.
command! -nargs=0 OR   :call     CocAction('runCommand', 'editor.action.organizeImport')

" Mappings for CoCList
" Show all diagnostics.
nnoremap <silent><nowait> <space>d  :<C-u>CocList diagnostics<cr>
" Manage extensions.
nnoremap <silent><nowait> <space>e  :<C-u>CocList extensions<cr>
" Show commands.
nnoremap <silent><nowait> <space>c  :<C-u>CocList commands<cr>
" Find symbol of current document.
nnoremap <silent><nowait> <space>o  :<C-u>CocList outline<cr>
" Search workspace symbols.
nnoremap <silent><nowait> <space>s  :<C-u>CocList -I symbols<cr>
" Do default action for next item.
nnoremap <silent><nowait> <space>j  :<C-u>CocNext<CR>
" Do default action for previous item.
nnoremap <silent><nowait> <space>k  :<C-u>CocPrev<CR>
" Resume latest coc list.
nnoremap <silent><nowait> <space>p  :<C-u>CocListResume<CR>d

[pianocomposer321]

I am also having this issue after doing :PlugUpdate. Coincidence or not, I am also using a pre-release version of neovim, NVIM v0.5.0-595-g08efa7037.

[pianocomposer321]

I tracked the offending commit down to bc97579 (Add all vim filetypes).

[sheerun]

I swear 90% issues I have are because of vim 8 packages or neovim ;(

[sheerun]

This is not a bug on vim-polyglot side. This is how vim highlighting looks like in upstream vim, problem solved

[sheerun]

just kidding, I've switched to neovim version of .vim highlighting, it should be fine now

[motorto]

Hey , doesn't seem to be working with markdown.

Using neovim as well.

Headers with polyglot don't get colored while without the plugin they do.

[sheerun]

it seems markdown highlighting is based on html highlighting for some reason and polyglot exchanges html higlighting to https://github.com/othree/html5.vim which is not compatible

[sheerun]

@motorto Should be fine now

[pianocomposer321]

@sheerun It's working for me! Thanks.