Skip to content

🔥 Remove duplicate this.type = null assigment #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dawidreedsy merged 1 commit into from
Mar 4, 2025
Merged

🔥 Remove duplicate this.type = null assigment #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/client/doc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ function Doc(connection, collection, id) {
this.id = id;

this.version = null;
// The OT type of this document. An uncreated document has type `null`
this.type = null;
this.data = undefined;

Expand Down Expand Up @@ -93,9 +94,6 @@ function Doc(connection, collection, id) {
// This is a list of {[create:{...}], [del:true], [op:...], callbacks:[...]}
this.pendingOps = [];

// The OT type of this document. An uncreated document has type `null`
this.type = null;

// The applyStack enables us to track any ops submitted while we are
// applying an op incrementally. This value is an array when we are
// performing an incremental apply and null otherwise. When it is an array,
Expand Down