Reduce test flakiness #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharedb-mongo has a dependency on tests in sharedb-mingo-memory. These tests were [recently fixed][1] in sharedb-mingo-memory. This change bumps the patch version of that dependency here so that the tests are fixed on this library, too. [1]: share/sharedb-mingo-memory#5
Contributor
|
This is essentially a subset of #64. |
Contributor
Author
|
This test is still flaky, though. I think there's a race condition here that sometimes fails. |
Contributor
Yes, I've seen this error in your previous PR too (different node and MongoDB version). I'd guess it could be the previous test affecting the failing test. |
Contributor
Author
|
I've attempted to fix this flaky test here: share/sharedb#227 |
Contributor
|
Your fix for the flaky base test is published as [email protected], so we can pick this back up now. You should be able to trigger a Travis re-run with the new published version by pushing up an empty commit to your branch, then deleting the commit and force-pushing once Travis starts running. |
alecgibson
force-pushed
the
reduce-test-flakiness
branch
from
7efee62 to
46f512f
Compare
alecgibson
force-pushed
the
reduce-test-flakiness
branch
from
46f512f to
fa734c9
Compare
ericyhwang
approved these changes
Aug 6, 2018
Contributor
ericyhwang
left a comment
ericyhwang
left a comment
There was a problem hiding this comment.
Thanks for the updates!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change attempts to reduce build flakiness by:
sharedb-mingo-memoryversion to a version which fixes its unit tests