fix: attempt at fixing wallet import on mobile #11768
Draft
+391
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en attempted Add saveAttemptedRef to prevent duplicate wallet saves when both handleViewWallet and handleClose could trigger saveAndSelectWallet. The ref is checked at the start of saveAndSelectWallet and set to true before proceeding with the save. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…) on mount This ensures the wallet is saved immediately when the CreateSuccess screen renders, rather than only when the user clicks the "View wallet" button. The existing saveAttemptedRef prevents duplicate save attempts. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ady been Add hasConnectedRef to prevent duplicate wallet connection attempts in ImportSuccess component. This follows the same pattern used in ManualBackup.tsx. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ction() Adds a useEffect hook that calls handleWalletConnection() on component mount. This ensures the wallet is connected immediately when ImportSuccess mounts, rather than only when the user clicks the close/view wallet button. Duplicate calls are prevented by the existing hasConnectedRef guard in handleWalletConnection(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NeOMakinG
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt at fixing the wallet import when quitting by closing the drawer instead of going to the wallet view
Issue (if applicable)
closes #11142
Risk
Low
Testing
TBD
Engineering
Operations
Screenshots (if applicable)
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.