Skip to content

Conversation

@klausi
Copy link

@klausi klausi commented Mar 18, 2018

While working on a minimum cargo dependency installer I noticed that this crate does not compile with matches 0.1.0.

cargo update -Z minimal-versions
    ...
    Updating matches v0.1.6 -> v0.1.0
    ...
cargo build
   Compiling matches v0.1.0
error: macros that expand to items must either be surrounded with braces or followed by a semicolon
  --> /home/klausi/.cargo/registry/src/git.colasdn.top-1ecc6299db9ec823/matches-0.1.0/lib.rs:4:21
   |
4  |   macro_rules! matches(
   |  _____________________^
5  | |     ($expression: expr, $($pattern:pat)|+) => (
6  | |         matches!($expression, $($pattern)|+ if true)
7  | |     );
...  |
13 | |     );
14 | | )
   | |_^

error: aborting due to previous error

error: Could not compile `matches`.

This change is Reviewable

@SimonSapin
Copy link
Member

This is an issue in matches, not in url. 0.1.0 doesn’t compile on recent Rust versions, and 0.1.1 doesn’t compile on the stable channel. I’ve "yanked" them from crates.io, they should now be ignored by Cargo unless already selected in a Cargo.lock file.

@SimonSapin SimonSapin closed this Mar 18, 2018
@klausi
Copy link
Author

klausi commented Mar 23, 2018

Thanks, that also works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants