core-graphics: Add CGKeyCodes for numpad keys #712
Conversation
core-graphics/src/event.rs
Outdated
| pub const RIGHT_ARROW: CGKeyCode = 0x7C; | ||
| pub const DOWN_ARROW: CGKeyCode = 0x7D; | ||
| pub const UP_ARROW: CGKeyCode = 0x7E; | ||
| pub const NUMPAD_0: CGKeyCode = 0x52; |
There was a problem hiding this comment.
Could we use the convention in original Ref?
So it should be KEYPAD_0 in this case.
There was a problem hiding this comment.
I agree, we should use the same name as the original reference. In addition, would it be possible to add all the missing key constants here and put them in the order of the original header file with comments indicating what section they came from?
There was a problem hiding this comment.
I added more constants, but I put them into new structs. Otherwise the comments would have been wrong. I also used the same names as in the original header file.
core-graphics/src/event.rs
Outdated
| pub const RIGHT_ARROW: CGKeyCode = 0x7C; | ||
| pub const DOWN_ARROW: CGKeyCode = 0x7D; | ||
| pub const UP_ARROW: CGKeyCode = 0x7E; | ||
| pub const NUMPAD_0: CGKeyCode = 0x52; |
There was a problem hiding this comment.
I agree, we should use the same name as the original reference. In addition, would it be possible to add all the missing key constants here and put them in the order of the original header file with comments indicating what section they came from?
pentamassiv
force-pushed
the
main
branch
3 times, most recently
from
164635f to
7efb5fb
Compare
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Sorry for the long delay. Thanks for included all of the keycodes! I think that only one small set of changes is necessary here.
| /// [Ref](https://github.com/phracker/MacOSX-SDKs/blob/master/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Headers/Events.h#L197-L261) | ||
| #[repr(C)] | ||
| pub struct ANSIKeyCode; | ||
| impl KeyCode { |
There was a problem hiding this comment.
Did you meant to write impl AnsiKeyCode here? In any case, I think you can just remove the new structures and keep only KeyCode, even though they are in separate enums in the Carbon headers, they are part of the same series of values. Separating seems unnecessary here.
There was a problem hiding this comment.
What do you want me to do with the doc comments? I think they add valuable information, but I don't know how to do that if they are not independent structs. Should they get deleted or merged?
There was a problem hiding this comment.
The documentation could be combined into one block for KeyCode explaining where all these values come from in CoreGraphics.
There was a problem hiding this comment.
Okay, I combined the comments. Is this how you imagined it?
Signed-off-by: Martin Robinson <[email protected]>
3 participants
The numpad keys also always have the same values