Skip to content

Correct screen capture access return values. #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2024
Merged

Correct screen capture access return values. #698

merged 1 commit into from
Aug 12, 2024

Conversation

@waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Aug 12, 2024

Both CGRequestScreenCaptureAccess and CGPreflightScreenCaptureAccess return bool, not boolean_t.

Fixes #677.
Replaces #678.

@waywardmonkeys
Correct screen capture access return values.
f2a6a79 
Both `CGRequestScreenCaptureAccess` and `CGPreflightScreenCaptureAccess`
return `bool`, not `boolean_t`.

Fixes servo#677.
Replaces servo#678.
@waywardmonkeys waywardmonkeys mentioned this pull request Aug 12, 2024
Closed
@jdm jdm added this pull request to the merge queue Aug 12, 2024
Merged via the queue into servo:main with commit e513e99 Aug 12, 2024
@waywardmonkeys waywardmonkeys mentioned this pull request Aug 12, 2024
Closed
@waywardmonkeys waywardmonkeys deleted the fix-screen-capture-access-return-values branch August 12, 2024 01:42
@tmandry tmandry mentioned this pull request Mar 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ScreenCaptureAccess.preflight returns incorrect value for Intel based 64bit Mac

2 participants

@waywardmonkeys @jdm