feat(CGDisplay): add displays_with_point and displays_with_rect #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjbray
force-pushed
the
cgdisplay-get-displays-with-point
branch
from
76a5f7b to
1a031c4
Compare
Collaborator
|
Can you add some tests? |
Contributor
Author
Added some simple tests. I'm not sure how to test anything more specific without mocking the displays somehow - any pointers on how to do that would be appreciated. |
Contributor
Author
|
I've also added |
mattjbray
force-pushed
the
cgdisplay-get-displays-with-point
branch
from
d80fec5 to
bf2881e
Compare
waywardmonkeys
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
CGDisplay::displays_with_pointandCGDisplay::displays_with_rect.Uses the pattern from
CGDisplay::active_displaysto first get the count of matching displays, then intialize the result Vec withvec![0; count as usize].