Skip to content

Conversation

@AsafFisher
Copy link
Contributor

@AsafFisher AsafFisher commented Jan 22, 2021

@AsafFisher AsafFisher changed the title WIP: Add CGEventTap WIP: Add CGEventTap - Initial CR needed Jan 22, 2021
@AsafFisher
Copy link
Contributor Author

AsafFisher commented Jan 23, 2021

Does anyone have any idea how to test this? Since you need to allow accessibility in order to use this feature.

@AsafFisher AsafFisher force-pushed the master branch 5 times, most recently from a7f0e9e to e1a1281 Compare January 23, 2021 18:18
@AsafFisher AsafFisher changed the title WIP: Add CGEventTap - Initial CR needed Add CGEventTap Jan 24, 2021
@AsafFisher
Copy link
Contributor Author

AsafFisher commented Jan 25, 2021

Can anyone CR it?
@jdm

Some(new_event) => new_event,
None => event,
};
ManuallyDrop::new(event).as_ptr()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments, why do I do that?

ManuallyDrop::new(event).as_ptr()
}


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derive Debug

unsafe {
let runloop_source_ref = CFMachPortCreateRunLoopSource(kCFAllocatorDefault, self.0, order);
if runloop_source_ref.is_null() {
Err(())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swipe Err and Ok

@AsafFisher
Copy link
Contributor Author

Somebody there?

@jrmuizel
Copy link
Collaborator

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 532a321 has been approved by jrmuizel

@bors-servo
Copy link
Contributor

⌛ Testing commit 532a321 with merge f7e0b97...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: jrmuizel
Pushing f7e0b97 to master...

@bors-servo bors-servo merged commit f7e0b97 into servo:master May 26, 2021
@Qyriad Qyriad mentioned this pull request Oct 28, 2021
bors-servo added a commit that referenced this pull request Nov 2, 2021
Publish core-graphics

Like #465, but for core-graphics. #436 in particular was merged five months ago, which was awesome, but there hasn't been a release to crates.io yet since then. Hopefully this PR should suffice for doing so?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants