Test that copying system fonts doesn't change the url #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
reviewed
Oct 26, 2020
Member
jdm
left a comment
jdm
left a comment
There was a problem hiding this comment.
thread 'font::copy_system_font' panicked at 'assertion failed: `(left == right)`
left: `Some(file:///System/Library/Fonts/SFNSDisplay-Regular.otf)`,
right: `Some(file:///System/Library/Fonts/SFNSText-Regular.otf)`', core-text/src/font.rs:672:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test font::copy_system_font ... FAILED
core-text/src/font.rs
Outdated
| fn copy_system_font() { | ||
| let small = unsafe { | ||
| CTFont::wrap_under_create_rule( | ||
| CTFontCreateUIFontForLanguage(kCTFontSystemDetailFontType, 19., std::ptr::null()) |
Collaborator
Author
There was a problem hiding this comment.
thread 'font::copy_system_font' panicked at 'assertion failed: `(left == right)` left: `Some(file:///System/Library/Fonts/SFNSDisplay-Regular.otf)`, right: `Some(file:///System/Library/Fonts/SFNSText-Regular.otf)`', core-text/src/font.rs:672:5 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace test font::copy_system_font ... FAILED
This was intentional. I plan to use these tests to help document the semantics of these functions.
Collaborator
Author
|
apologies for the garbage macos_version() function |
jrmuizel
force-pushed
the
copy-system
branch
6 times, most recently
from
b2f1089 to
524237c
Compare
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 11247e3 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.