`[NSEvent type]` produces value `21` with no associated `NSEventType` variant causing SEGFAULT.

[bors-servo]

Issue by mitchmindtree
Sunday Feb 05, 2017 at 08:19 GMT
Originally opened as https://github.com/servo/cocoa-rs/issues/155

---

The NSEvent::eventType method produces the value 21 when spotlight is opened or one of the items on the system menu tray are opened (e.g. battery status, wifi). The value has no associated variant within the NSEventType enum and thus segfaults when a user attempts to match against a NSEventType of value 21. This was causing a segfault in winit. I've added a commit to winit that side-steps this bug, however this should be properly fixed upstream in this crate. I've been unable to find any documentation on NSEventTypes of value 21 just yet.

[bors-servo]

Comment by jdm
Sunday Feb 05, 2017 at 15:36 GMT

---

I wonder if we should make eventType() return an Option to avoid any similar cases.

[bors-servo]

Comment by iszak
Friday Aug 18, 2017 at 23:33 GMT

---

@mitchmindtree In case you never found what the missing event types, they should be the following

• 0 NullEvent
• 21 ProcessNotification
• 32 SmartMagnify
• 33 QuickLook
• 35 Reserved
• 36 Reserved
• 37 Translate

Since they're not documented I assume these are private events and should not be relied on.

[bors-servo]

Comment by mitchmindtree
Saturday Aug 19, 2017 at 14:18 GMT

---

@iszak nice! Do you have any references for these events? Or did you just find them by experimenting?

[bors-servo]

Comment by iszak
Saturday Aug 19, 2017 at 14:51 GMT

---

@mitchmindtree I found them by disassembling AppKit, my assembly is not great so there is a chance these are wrong. But in the assembly the events were in order of their corresponding numbers.