-
Notifications
You must be signed in to change notification settings - Fork 238
Open
Description
Issue by application-developer-DA
Tuesday Apr 04, 2017 at 16:07 GMT
Originally opened as servo/core-graphics-rs#81
I've noticed several problems when worked with the code:
- Some inconsistencies in coding style: the order of
usestatements varies between files (it would be better to use the same style / order everywhere; one of the possible styles). - When multiple functions/structures/types are imported from the module, both
use something::{str1, test, example}anduse something::{ str1, test, example }styles are used, it would be nice to stick to one of the versions. - Sometimes the text width is more than 100 characters.
- There is a lot of boilerplate code in each module when it comes to
TCFTypetrait implementation. I think it makes sense to useimpl_TCFType!macro fromcore-foundation-sysor something similar.
Metadata
Metadata
Assignees
Labels
No labels