Skip to content

PERF-281: Optimize SqlQueryStatement #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

PERF-281: Optimize SqlQueryStatement #387

merged 1 commit into from
May 29, 2025

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented May 29, 2025 •
edited
Loading

In queries .Hints, .OrderBy, .GroupBy are empty frequently.
No need to allocate Collection/List for them just to enumerate it

Also:

  • Make some enums byte-size
  • Don't check for null before SqlValidator.EnsureIsBooleanExpression(value) - it allows null as input

@SergeiPavlov SergeiPavlov merged commit 950e833 into master-servicetitan May 29, 2025
5 checks passed
@SergeiPavlov SergeiPavlov deleted the SqlSelect branch May 29, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botinko botinko botinko approved these changes

@snaumenko-st snaumenko-st Awaiting requested review from snaumenko-st

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergeiPavlov @botinko @snaumenko-st