Optimization: Dispatch Translator by virtual functions instead of switch statements #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botinko
approved these changes
Jun 20, 2023
SergeiPavlov
added a commit
that referenced
this pull request
Jan 4, 2024
…tch statements (#118) * Optimization: Dispatch Translator by virtual functions instead of switch statements * AppendSpacePrefixed() helper * Refactor ColumnSection * virtual JoinCondition() * Eliminate IfSection * Eliminate InsertSection * LikeSection * BetweenSection * FetchSection * WhileSection * SqlOrder * UpdateSection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Virtual-function dispatching minimizes number of branches, which is a bottleneck in CPU
This approach applied to
SELECTtranslator only as an example.Can be propagated to other frequently used SQL statements
Also: