-
Notifications
You must be signed in to change notification settings - Fork 4
refactor(cli_tools): Deprecated CommandDocumentationGenerator #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdded a deprecation annotation to the public class Changes
Sequence Diagram(s)(omitted — changes do not affect control flow) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-06-12T14:55:38.006ZApplied to files:
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/cli_tools/lib/src/documentation_generator/documentation_generator.dart (1)
3-4: Improve deprecation message consistency with codebase patterns and clarify for public API users.The class is publicly exported through the package (via
cli_tools.dart→docs_generator.dart), so the deprecation affects external users. Review other deprecations in the codebase (e.g., inpackages/config/lib/src/config/config_parser.dart) which follow the pattern of providing migration guidance ("Use X instead").Update the deprecation message to:
- Provide explicit migration guidance (what should users do instead?)
- Replace "in the future" with a specific version target
- Consider whether test usage needs deprecation handling (currently tests will emit warnings when using this class)
Example improved message:
@Deprecated( 'This is highly use case specific and will be removed in version 2.0.0. ' 'Please implement custom documentation generation in your own codebase if needed.')
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/cli_tools/lib/src/documentation_generator/documentation_generator.dart(1 hunks)
SandPod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
CommandDocumentationGenerator is highly use case specific, no longer used by cloud, and will be removed from this package in the future as it does not fit with general purpose components and is not a priority to develop into one.
a22b5f6 to
296738c
Compare
CommandDocumentationGenerator is highly use case specific, no longer used by cloud, and will be removed from this package in the future as it does not fit with general purpose components and is not a priority to develop into one.
Summary by CodeRabbit
Chores
Tests