Skip to content

Conversation

robinson
Copy link
Contributor

@robinson robinson commented Oct 30, 2024

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it: CI/CD flow to publish helm chart

Special notes for reviewers: need another step to publish into https://artifacthub.io/

Additional information (if needed):

@JBBianchi
Copy link
Member

Hi @robinson, thanks a lot for your PR !

But as you can see, it doesn't pass the DCO requirements. Could you please sign/verify and sign off your commits ?

Signed-off-by: lth <[email protected]>
@cdavernas cdavernas added priority: low Indicates a low priority issue weight: 2 An issue with a low development impact type: fix labels Oct 30, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Oct 30, 2024
@cdavernas cdavernas linked an issue Oct 30, 2024 that may be closed by this pull request
@cdavernas cdavernas added type: enhancement New feature or request runtime: kubernetes Concerns the Kubernetes runtime host and removed type: fix labels Oct 30, 2024
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

@JBBianchi
Copy link
Member

Btw, should this PR be merged in main or in gh-pages ?

Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
@robinson
Copy link
Contributor Author

Btw, should this PR be merged in main or in gh-pages ?

the gh-pages branch use to create a pages in order to publish the artifacts. The helm release workflow should be run in main branch.

@cdavernas cdavernas merged commit ff53a45 into serverlessworkflow:main Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Indicates a low priority issue runtime: kubernetes Concerns the Kubernetes runtime host type: enhancement New feature or request weight: 2 An issue with a low development impact
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add CI/CD workflow to package Helm charts
3 participants