Skip to content

Fix output examples from dsl reference and ctk feature #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

yzhao244
Copy link
Contributor

@yzhao244 yzhao244 commented Jul 25, 2024

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

Fixes #934

What this PR does:

Some fixes to specification version : 1.0.0-alpha

  • Fixes output property "as" from two of the examples in the call feature in ctk
  • Fixes output property "as" and remove "from" against the example of Output in DSL reference.

Additional information:

Please review in case I misinterpreted any examples of Output in either CTK or DSL reference.

Signed-off-by: Yuri Zhao <[email protected]>
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yzhao244 ❤️

@ricardozanini ricardozanini merged commit 4622e24 into serverlessworkflow:main Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSL reference Output example
4 participants