Skip to content

DSL reference Output example #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yzhao244 opened this issue Jul 24, 2024 · 5 comments · Fixed by #936
Closed

DSL reference Output example #934

yzhao244 opened this issue Jul 24, 2024 · 5 comments · Fixed by #936

Comments

@yzhao244
Copy link
Contributor

In the DSL reference, I noticed the examples of Output component, I don't think I can define "from" and "to" for Output properties, right. If I am not mistaken lol, I can submit PR to correct this example.

https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#output

schema:
  format: json
  document:
    type: object
    properties:
      petId:
        type: string
    required: [ petId ]
from:                         ## remove from 
  petId: '${ .pet.id }'   ## remove this line
to: '.petList += [ . ]'   ## replace to with as
  • Specification version used:
    1.0.0-alpha
@cdavernas
Copy link
Member

cdavernas commented Jul 24, 2024

@yzhao244 Great catch! You are totally right!

output.from should actually be output.as and output.to should be export.to.

I'm not sure how the examples could be validated though, as the CI/CD pipeline should have caught those mistakes 😞

@matthias-pichler
Copy link
Collaborator

@cdavernas
The current schema does specify export.as

@cdavernas
Copy link
Member

@matthias-pichler-warrify yes sorry, my bad 😉

@yzhao244
Copy link
Contributor Author

@cdavernas @matthias-pichler-warrify Thanks guys for the comments... submitted a PR for updating this example. #936

@cdavernas
Copy link
Member

Thanks @yzhao244! I will let the pleasure to @ricardozanini to merge it once he could review it. He's gonna be back from PTO in a couple of days 😉

@github-project-automation github-project-automation bot moved this from Backlog to Done in Progress Tracker Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants