Skip to content

Updates schema to enforce names as required RFC1123 values #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Updates schema to enforce names as required RFC1123 values #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0bdb2e4
Updates schemas to enforce names as required RFC1123 values
cdavernas May 26, 2023
419e030
Merge branch 'main' into feat-enforce-naming-conventions
cdavernas May 26, 2023
1b8408a
fix: Added missing `Naming Convention` documentation section
cdavernas May 26, 2023
ace0f32
fix: Updated other missing schemas
cdavernas May 26, 2023
2439eea
Replaced name regex by one that forbids double dashes
cdavernas May 30, 2023
4d0b236
Update specification.md
cdavernas May 30, 2023
0f89dd1
Added the name regex tp specification.md
cdavernas May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion schema/auth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
"name": {
"type": "string",
"description": "Unique auth definition name",
"minLength": 1
"minLength": 1,
"pattern": "^[a-z0-9](-?[a-z0-9])*$"
},
"scheme": {
"type": "string",
Expand Down
3 changes: 2 additions & 1 deletion schema/errors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
"name": {
"type": "string",
"description": "Domain-specific error name",
"minLength": 1
"minLength": 1,
"pattern": "^[a-z0-9](-?[a-z0-9])*$"
},
"code": {
"type": "string",
Expand Down
3 changes: 2 additions & 1 deletion schema/events.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
"name": {
"type": "string",
"description": "Unique event name",
"minLength": 1
"minLength": 1,
"pattern": "^[a-z0-9](-?[a-z0-9])*$"
},
"source": {
"type": "string",
Expand Down
9 changes: 6 additions & 3 deletions schema/functions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
"name": {
"type": "string",
"description": "Unique function name",
"minLength": 1
"minLength": 1,
"pattern": "^[a-z0-9](-?[a-z0-9])*$"
},
"operation": {
"type": "string",
Expand All @@ -58,7 +59,8 @@
{
"type": "string",
"description": "References the auth definition to be used to invoke the operation",
"minLength": 1
"minLength": 1,
"pattern": "^[a-z0-9](-?[a-z0-9])*$"
},
{
"type": "object",
Expand All @@ -67,7 +69,8 @@
"resource":{
"type": "string",
"description": "References an auth definition to be used to access the resource defined in the operation parameter",
"minLength": 1
"minLength": 1,
"pattern": "^[a-z0-9](-?[a-z0-9])*$"
},
"invocation":{
"type": "string",
Expand Down
3 changes: 2 additions & 1 deletion schema/retries.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
"name": {
"type": "string",
"description": "Unique retry strategy name",
"minLength": 1
"minLength": 1,
"pattern": "^[a-z0-9](-?[a-z0-9])*$"
},
"delay": {
"type": "string",
Expand Down
Loading