-
Notifications
You must be signed in to change notification settings - Fork 159
Simplify data filter property names #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify data filter property names #702
Conversation
… instead of `stateDataFilter`, `actionDataFilter`, etc. Signed-off-by: Charles d'Avernas <[email protected]>
thanks for pr! def +1 but would like if possible to wait till we deal with callback state this change even tho again +1 would put spec in an inconsistent state until like you mentioned we deal with the callback state which still with your changes includes:
Are you ok with leaving this up and then add it as soon as we figure out the callback state questions? |
@tsurdilo yeah, sure! It's just a cosmetic update anyways ;) |
roadmap update reminder :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update roadmap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs roadmap, let me know when should review again. thanks.
Will do asap, thanks! |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@tsurdilo The roadmap has finally been updated ;) Sorry for the very long delay, had forgot about the PR |
@tsurdilo can you please take a look? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bug: requested changes have all been addressed but is still marked
Have to refactor that one too :( Not surprisingly, became stale after like 2 years of sitting here |
Closed as part of #843 |
Many thanks for submitting your Pull Request ❤️!
Please specify parts of this PR update:
Discussion or Issue link:
#672
What this PR does / why we need it:
Simplifies data filter property names, which are uselessly verbose
Special notes for reviewers:
The change applies to all concepts, except for the
callbackState
which exposes two filters at top level (stateDataFilter
andeventDataFilter
), which should anyways disapear if we go through with atomic produce/consume actions. If we keep thecallbackState
, we should then move theeventDataFilter
down anevent
property, to ensure coherence accross the spec.