Skip to content

Rename data filter properties #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdavernas opened this issue Sep 9, 2022 · 6 comments
Closed

Rename data filter properties #672

cdavernas opened this issue Sep 9, 2022 · 6 comments
Assignees
Labels
area: spec Changes in the Specification change: feature New feature or request. Impacts in a minor version change
Milestone

Comments

@cdavernas
Copy link
Member

cdavernas commented Sep 9, 2022

What would you like to be added:

To rename data filter properties

Why is this needed:

Having properties such as stateDataFilter when defining a state, or actionDataFilter when defining an action is redudant and tedious to write. So, instead of:

...
states:
- name: MyOperationState
  type: operation
  stateDataFilter: ...
  actions:
    - name: MyAction
      actionDataFilter: ...
      ...
...

... I propose we use:

...
states:
- name: MyOperationState
  type: operation
  dataFilter: ...
  actions:
    - name: MyAction
      dataFilter: ...
      ...
...

IMHO it's less confusing, shorter and cleaner.

@tsurdilo
Copy link
Contributor

tsurdilo commented Sep 9, 2022

agree but much harder to define cleanly in json schema :) looking into it to see if there is nice way

@tsurdilo tsurdilo added the change: feature New feature or request. Impacts in a minor version change label Sep 12, 2022
@tsurdilo tsurdilo added this to the v0.9 milestone Sep 12, 2022
@cdavernas cdavernas added area: spec Changes in the Specification schema labels Sep 13, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this as completed Apr 8, 2023
@ricardozanini ricardozanini reopened this Apr 27, 2023
@cdavernas cdavernas moved this from Todo to In Progress in Progress Tracker May 30, 2023
@cdavernas cdavernas linked a pull request May 30, 2023 that will close this issue
9 tasks
@cdavernas cdavernas self-assigned this May 30, 2023
@cdavernas
Copy link
Member Author

cdavernas commented May 17, 2024

Closed as resolved by 1.0.0-alpha1, and therefore as part of #843

@github-project-automation github-project-automation bot moved this from In Progress to Done in Progress Tracker May 17, 2024
@cdavernas cdavernas mentioned this issue May 20, 2024
9 tasks
@cdavernas cdavernas mentioned this issue May 21, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification change: feature New feature or request. Impacts in a minor version change
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants