Skip to content

Force id to be mandatory #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Force id to be mandatory #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/src/main/resources/schema/workflow.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@
}
},
"required": [
"id",
"name",
"version",
"states"
Expand Down
7 changes: 3 additions & 4 deletions validation/src/test/java/io/serverlessworkflow/validation/test/WorkflowValidationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public void testIncompleteYamlWithSchemaValidation() {
List<ValidationError> validationErrors =
workflowValidator.setSource("---\n" + "key: abc\n").validate();
Assertions.assertNotNull(validationErrors);
Assertions.assertEquals(3, validationErrors.size());
Assertions.assertEquals(4, validationErrors.size());
}

@Test
Expand Down Expand Up @@ -119,11 +119,10 @@ public void testWorkflowMissingStatesIdAndKey() {
+ "}")
.validate();
Assertions.assertNotNull(validationErrors);
Assertions.assertEquals(2, validationErrors.size());
Assertions.assertEquals(1, validationErrors.size());

Assertions.assertEquals(
"Workflow id or key should not be empty", validationErrors.get(0).getMessage());
Assertions.assertEquals("No states found", validationErrors.get(1).getMessage());
"$.id: is missing but it is required", validationErrors.get(0).getMessage());
}

@Test
Expand Down